Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add purchasers while doing setup for primary admin. #9540

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions assets/js/modules/analytics-4/datastore/audiences.js
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,29 @@ const baseActions = {
configuredAudiences.push( ...audiences );
}

if ( configuredAudiences.length === 1 ) {
// Add 'Purchasers' audience if it has data.
const purchasersAudience = availableAudiences.find(
( { audienceSlug } ) => audienceSlug === 'purchasers'
);

if ( purchasersAudience ) {
const purchasersResourceDataAvailabilityDate =
yield commonActions.await(
resolveSelect(
MODULES_ANALYTICS_4
).getResourceDataAvailabilityDate(
purchasersAudience.name,
RESOURCE_TYPE_AUDIENCE
)
);

if ( purchasersResourceDataAvailabilityDate ) {
configuredAudiences.push( purchasersAudience.name );
}
}
}

if ( configuredAudiences.length === 0 ) {
const requiredAudienceSlugs = [
'new-visitors',
Expand Down
73 changes: 73 additions & 0 deletions assets/js/modules/analytics-4/datastore/audiences.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1095,6 +1095,79 @@ describe( 'modules/analytics-4 audiences', () => {
).toEqual( expectedConfiguredAudiences );
} );

it( 'should add "purchasers" audience to `configuredAudiences` if it has data and there is only one audience available in `configuredAudiences`', async () => {
const userAudience = availableAudiencesFixture[ 4 ];

const availableAudiences = [
userAudience,
availableAudiencesFixture[ 1 ], // Purchaser
];

registry
.dispatch( MODULES_ANALYTICS_4 )
.receiveResourceDataAvailabilityDates( {
audience: availableAudiences.reduce(
( acc, { name } ) => {
acc[ name ] = 20201220;

return acc;
},
{}
),
customDimension: {},
property: {},
} );

fetchMock.postOnce( syncAvailableAudiencesEndpoint, {
body: availableAudiences,
status: 200,
} );

const options = registry
.select( MODULES_ANALYTICS_4 )
.getAudiencesUserCountReportOptions( [ userAudience ], {
startDate,
endDate: referenceDate,
} );

registry.dispatch( MODULES_ANALYTICS_4 ).receiveGetReport(
createAudiencesTotalUsersMockReport( {
[ userAudience.name ]: 123,
} ),
{ options }
);

registry
.dispatch( MODULES_ANALYTICS_4 )
.finishResolution( 'getReport', [ options ] );

const expectedConfiguredAudiences = availableAudiences.map(
( { name } ) => name
);

fetchMock.postOnce( audienceSettingsEndpoint, {
body: {
configuredAudiences: expectedConfiguredAudiences,
isAudienceSegmentationWidgetHidden,
},
status: 200,
} );

muteFetch( expirableItemEndpoint );

await registry
.dispatch( MODULES_ANALYTICS_4 )
.enableAudienceGroup();

const getConfiguredAudiences = registry
.select( CORE_USER )
.getConfiguredAudiences();

expect( getConfiguredAudiences ).toEqual(
expectedConfiguredAudiences
);
} );

it( 'should make a request to expire new badges for configured audiences', async () => {
const totalUsersByAudience = {
[ availableUserAudiences[ 0 ].name ]: 0,
Expand Down
Loading