Follow Up PR: Fix Key Metrics tests failing due to updated list of conversiontailored metrics.

[benbowler]

Summary

Addresses issue:

• Update tailored metrics to also include new ACR metrics #9437

Relevant technical choices

PR Author Checklist

• My code is tested and passes existing unit tests.
• My code has an appropriate set of unit tests which all pass.
• My code is backward-compatible with WordPress 5.2 and PHP 7.4.
• My code follows the WordPress coding standards.
• My code has proper inline documentation.
• I have added a QA Brief on the issue linked above.
• I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

• Run the code.
• Ensure the acceptance criteria are satisfied.
• Reassess the implementation with the IB.
• Ensure no unrelated changes are included.
• Ensure CI checks pass.
• Check Storybook where applicable.
• Ensure there is a QA Brief.
• Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

• Ensure the PR has the correct target branch.
• Double-check that the PR is okay to be merged.
• Ensure the corresponding issue has a ZenHub release assigned.
• Add a changelog message to the issue.

[techanvil]

Thanks @benbowler, this looks good. I've left a couple of minor suggestions, sending it back you way to confirm/update.

[techanvil]

Hmm, if I've understood things correctly the new set of metrics is a mix of the old/non-conversion and conversion based metrics, so it would be good to rename this variable e.g. expectedMetricsIncludingConversionTailored or something along those lines...

Suggested change

	).toEqual( conversionTailoredMetrics );
	).toEqual( expectedMetricsIncludingConversionTailored );

[techanvil]

It would be good to update this comment to be a bit more accurate, e.g. something like this:

Suggested change

	// Conversion Tailored Metrics should be added to the list if the
	// includeConversionTailoredMetrics setting is true.
	// Conversion Tailored Metrics should be included in the list if the
	// includeConversionTailoredMetrics setting is true.

[techanvil]

@benbowler I just realised this needs to target main as it's a 1.138.0 release issue. I've updated the target for the PR.

[benbowler]

Thanks @techanvil, yes agreed your points would clarify the description and variable name.

[techanvil]

Great, thanks @benbowler. LGTM!