Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Analytics VRT. #9516

Merged
merged 5 commits into from
Oct 16, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, although it's commendable in principle to fix this here, the GoogleTagIDMismatchNotification VRT already has a fix in the open PR #9469, as mentioned previously on Slack. It looks like that fix avoids the need to recreate the reference images for it.

As it's out of scope for this issue, I'd suggest backing out the change to avoid creating a conflict for the other PR and updating the reference images unnecessarily...

Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,28 @@ AlternativeGA4Config.decorators = [
gtmContainerID
];

const accountID =
fixtures.accountSummaries.accountSummaries[ 1 ]._id;
const properties =
fixtures.accountSummaries.accountSummaries[ 1 ]
.propertySummaries;

registry
.dispatch( MODULES_ANALYTICS_4 )
.receiveGetAccountSummaries( fixtures.accountSummaries );
registry
.dispatch( MODULES_ANALYTICS_4 )
.finishResolution( 'getAccountSummaries', [] );

registry
.dispatch( MODULES_ANALYTICS_4 )
.receiveGetProperties( properties, {
accountID,
} );
registry
.dispatch( MODULES_ANALYTICS_4 )
.finishResolution( 'getProperties', [ accountID ] );

registry
.dispatch( MODULES_ANALYTICS_4 )
.setGoogleTagAccountID( gtmAccountID );
Expand All @@ -66,6 +88,7 @@ AlternativeGA4Config.decorators = [
];
AlternativeGA4Config.scenario = {
label: 'Global/GoogleTagIDMismatchNotification/AlternativeGA4Config',
delay: 1000,
};

export const NoAlternativeGA4Config = Template.bind( {} );
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading