Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #9407

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update Dockerfile #9407

wants to merge 1 commit into from

Conversation

sharkeshd
Copy link

Explanation:
Builder Stage:

Install all necessary packages, including backstopjs. Clean up the npm cache to reduce image size.
Runtime Stage:

Install only the runtime dependencies required for running backstopjs. Copy the backstopjs installation from the builder stage to avoid reinstalling it. Benefits:
Smaller Image Size: By separating build and runtime, you only include what's necessary in the final image. Clean Environment: The final image does not contain build tools, making it more secure and efficient.

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Explanation:
Builder Stage:

Install all necessary packages, including backstopjs.
Clean up the npm cache to reduce image size.
Runtime Stage:

Install only the runtime dependencies required for running backstopjs.
Copy the backstopjs installation from the builder stage to avoid reinstalling it.
Benefits:
Smaller Image Size: By separating build and runtime, you only include what's necessary in the final image.
Clean Environment: The final image does not contain build tools, making it more secure and efficient.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant