Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvproxy: Qualify NVIDIA driver version 560.35.03. #11105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Nov 1, 2024

nvproxy: Qualify NVIDIA driver version 560.35.03.

Successful run of the tests:
https://buildkite.com/gvisor/pipeline/builds/33022
(This was with a version of pipeline.yaml that enables the COS GPU tests
and the "All GPU drivers" test)

Diff between 550.90.07 and 560.35.03:

I1101 14:36:12.467749  1074191 run_differ.go:110] Parsing driver version 550.90.07
I1101 14:36:21.315552  1074191 run_differ.go:115] Parsing driver version 560.35.03
I1101 14:36:29.595380  1074191 run_differ.go:123] Comparing record definitions between 550.90.07 and 560.35.03
I1101 14:36:29.595479  1074191 run_differ.go:140] type NVC36F_CTRL_GET_CLASS_ENGINEID_PARAMS not found in second source file
I1101 14:36:29.595485  1074191 run_differ.go:136] type NV2080_CTRL_BUS_PCIE_GPU_ATOMIC_OP_INFO not found in first source file
I1101 14:36:29.595603  1074191 run_differ.go:147]
--- A: /tmp/run_differ_2014218811/run_differ_3207981357/550.90.07/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080gpu.h:1206:16
+++ B: /tmp/run_differ_2014218811/run_differ_1071705113/560.35.03/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080gpu.h:1213:16
struct NV2080_CTRL_GPU_QUERY_ECC_STATUS_PARAMS
  size: 1024 -> 1264 (bytes)
  []parser.RecordField{
        {
                Name: "units",
                Type: strings.Join({
                        "NV2080_CTRL_GPU_QUERY_ECC_UNIT_STATUS[",
-                       "25",
+                       "31",
                        "]",
                }, ""),
                Offset: 0,
        },
        {
                Name:   "bFatalPoisonError",
                Type:   "NvBool",
-               Offset: 1000,
+               Offset: 1240,
        },
        {
                Name:   "uncorrectableError",
                Type:   "NvU8",
-               Offset: 1001,
+               Offset: 1241,
        },
        {
                Name:   "flags",
                Type:   "NvU32",
-               Offset: 1004,
+               Offset: 1244,
        },
        {
                Name:   "grRouteInfo",
                Type:   "NV2080_CTRL_GR_ROUTE_INFO",
-               Offset: 1008,
+               Offset: 1248,
        },
  }

I1101 14:36:29.595746  1074191 run_differ.go:147]
--- A: /tmp/run_differ_2014218811/run_differ_3207981357/550.90.07/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080nvlink.h:264:16
+++ B: /tmp/run_differ_2014218811/run_differ_1071705113/560.35.03/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080nvlink.h:275:16
struct NV2080_CTRL_NVLINK_LINK_STATUS_INFO
  size: 184 -> 192 (bytes)
  []parser.RecordField{
        ... // 24 identical elements
        {Name: "localLinkSid", Type: "NvU64", Offset: 72},
        {Name: "laneRxdetStatusMask", Type: "NvU32", Offset: 80},
+       s"NvU32 nvlinkMinL1Threshold",
        {
-               Name:   "remoteDeviceInfo",
+               Name:   "nvlinkMaxL1Threshold",
-               Type:   "NV2080_CTRL_NVLINK_DEVICE_INFO",
+               Type:   "NvU32",
                Offset: 88,
        },
+       s"NvU32 nvlinkL1ThresholdUnits",
        {
-               Name:   "localDeviceInfo",
+               Name:   "remoteDeviceInfo",
                Type:   "NV2080_CTRL_NVLINK_DEVICE_INFO",
-               Offset: 136,
+               Offset: 96,
        },
+       s"NV2080_CTRL_NVLINK_DEVICE_INFO localDeviceInfo",
  }

I1101 14:36:29.595784  1074191 run_differ.go:147]
--- A: /tmp/run_differ_2014218811/run_differ_3207981357/550.90.07/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080gpu.h:755:16
+++ B: /tmp/run_differ_2014218811/run_differ_1071705113/560.35.03/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080gpu.h:762:16
struct NV2080_CTRL_GPU_GET_ENGINES_V2_PARAMS
  size: 260 -> 340 (bytes)
  []parser.RecordField{
        {Name: "engineCount", Type: "NvU32"},
        {
                Name:   "engineList",
-               Type:   "NvU32[64]",
+               Type:   "NvU32[84]",
                Offset: 4,
        },
  }

I1101 14:36:29.595806  1074191 run_differ.go:147]
--- A: /tmp/run_differ_2014218811/run_differ_3207981357/550.90.07/src/common/sdk/nvidia/inc/ctrl/ctrl0080/ctrl0080gpu.h:511:16
+++ B: /tmp/run_differ_2014218811/run_differ_1071705113/560.35.03/src/common/sdk/nvidia/inc/ctrl/ctrl0080/ctrl0080gpu.h:512:16
struct NV0080_CTRL_GPU_GET_CLASSLIST_V2_PARAMS
  size: 700 -> 404 (bytes)
  []parser.RecordField{
        {Name: "numClasses", Type: "NvU32"},
        {
                Name:   "classList",
-               Type:   "NvU32[174]",
+               Type:   "NvU32[100]",
                Offset: 4,
        },
  }

I1101 14:36:29.595829  1074191 run_differ.go:147]
--- A: /tmp/run_differ_2014218811/run_differ_3207981357/550.90.07/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080bus.h:1354:16
+++ B: /tmp/run_differ_2014218811/run_differ_1071705113/560.35.03/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080bus.h:1311:16
struct NV2080_CTRL_CMD_BUS_GET_PCIE_SUPPORTED_GPU_ATOMICS_PARAMS
  size: 104 -> 112 (bytes)
  []parser.RecordField{
        {
-               Name:   "atomicOp",
+               Name:   "capType",
-               Type:   "NV2080_CTRL_CMD_BUS_GET_PCIE_SUPPORTED_GPU_ATOMICS_PARAMS::atomicOp_t[13]",
+               Type:   "NvU32",
                Offset: 0,
        },
+       s"NvU32 dbdf",
+       s"NV2080_CTRL_BUS_PCIE_GPU_ATOMIC_OP_INFO[13] atomicOp",
  }

I1101 14:36:29.595859  1074191 run_differ.go:147]
--- A: /tmp/run_differ_2014218811/run_differ_3207981357/550.90.07/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080fb.h:423:16
+++ B: /tmp/run_differ_2014218811/run_differ_1071705113/560.35.03/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080fb.h:451:16
struct NV2080_CTRL_FB_GET_INFO_V2_PARAMS
  size: 444 -> 460 (bytes)
  []parser.RecordField{
        {Name: "fbInfoListSize", Type: "NvU32"},
        {
                Name:   "fbInfoList",
-               Type:   "NV2080_CTRL_FB_INFO[55]",
+               Type:   "NV2080_CTRL_FB_INFO[57]",
                Offset: 4,
        },
  }

I1101 14:36:29.595883  1074191 run_differ.go:147]
--- A: /tmp/run_differ_2014218811/run_differ_3207981357/550.90.07/src/common/sdk/nvidia/inc/ctrl/ctrl0080/ctrl0080gpu.h:311:16
+++ B: /tmp/run_differ_2014218811/run_differ_1071705113/560.35.03/src/common/sdk/nvidia/inc/ctrl/ctrl0080/ctrl0080gpu.h:311:16
struct NV0080_CTRL_GPU_GET_VIRTUALIZATION_MODE_PARAMS
  size: 4 -> 8 (bytes)
  []parser.RecordField{
        {Name: "virtualizationMode", Type: "NvU32"},
+       s"NvBool isGridBuild",
  }

I1101 14:36:29.595910  1074191 run_differ.go:147]
--- A: /tmp/run_differ_2014218811/run_differ_3207981357/550.90.07/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080nvlink.h:399:16
+++ B: /tmp/run_differ_2014218811/run_differ_1071705113/560.35.03/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080nvlink.h:429:16
struct NV2080_CTRL_CMD_NVLINK_GET_NVLINK_STATUS_PARAMS
  size: 5896 -> 6152 (bytes)

I1101 14:36:29.595915  1074191 run_differ.go:140] type NV2080_CTRL_CMD_BUS_GET_PCIE_SUPPORTED_GPU_ATOMICS_PARAMS::atomicOp_t not found in second source file
I1101 14:36:29.595922  1074191 run_differ.go:151] Comparing type aliases between 550.90.07 and 560.35.03

Fixes #11104

@copybara-service copybara-service bot added the exported Issue was exported automatically label Nov 1, 2024
@copybara-service copybara-service bot force-pushed the test/cl692298807 branch 5 times, most recently from f7de447 to 99f066a Compare November 2, 2024 01:47
Successful run of the tests:
https://buildkite.com/gvisor/pipeline/builds/33022
(This was with a version of `pipeline.yaml` that enables the COS GPU tests
and the "All GPU drivers" test)

Diff between `550.90.07` and `560.35.03`:

```
I1101 14:36:12.467749  1074191 run_differ.go:110] Parsing driver version 550.90.07
I1101 14:36:21.315552  1074191 run_differ.go:115] Parsing driver version 560.35.03
I1101 14:36:29.595380  1074191 run_differ.go:123] Comparing record definitions between 550.90.07 and 560.35.03
I1101 14:36:29.595479  1074191 run_differ.go:140] type NVC36F_CTRL_GET_CLASS_ENGINEID_PARAMS not found in second source file
I1101 14:36:29.595485  1074191 run_differ.go:136] type NV2080_CTRL_BUS_PCIE_GPU_ATOMIC_OP_INFO not found in first source file
I1101 14:36:29.595603  1074191 run_differ.go:147]
--- A: /tmp/run_differ_2014218811/run_differ_3207981357/550.90.07/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080gpu.h:1206:16
+++ B: /tmp/run_differ_2014218811/run_differ_1071705113/560.35.03/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080gpu.h:1213:16
struct NV2080_CTRL_GPU_QUERY_ECC_STATUS_PARAMS
  size: 1024 -> 1264 (bytes)
  []parser.RecordField{
        {
                Name: "units",
                Type: strings.Join({
                        "NV2080_CTRL_GPU_QUERY_ECC_UNIT_STATUS[",
-                       "25",
+                       "31",
                        "]",
                }, ""),
                Offset: 0,
        },
        {
                Name:   "bFatalPoisonError",
                Type:   "NvBool",
-               Offset: 1000,
+               Offset: 1240,
        },
        {
                Name:   "uncorrectableError",
                Type:   "NvU8",
-               Offset: 1001,
+               Offset: 1241,
        },
        {
                Name:   "flags",
                Type:   "NvU32",
-               Offset: 1004,
+               Offset: 1244,
        },
        {
                Name:   "grRouteInfo",
                Type:   "NV2080_CTRL_GR_ROUTE_INFO",
-               Offset: 1008,
+               Offset: 1248,
        },
  }

I1101 14:36:29.595746  1074191 run_differ.go:147]
--- A: /tmp/run_differ_2014218811/run_differ_3207981357/550.90.07/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080nvlink.h:264:16
+++ B: /tmp/run_differ_2014218811/run_differ_1071705113/560.35.03/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080nvlink.h:275:16
struct NV2080_CTRL_NVLINK_LINK_STATUS_INFO
  size: 184 -> 192 (bytes)
  []parser.RecordField{
        ... // 24 identical elements
        {Name: "localLinkSid", Type: "NvU64", Offset: 72},
        {Name: "laneRxdetStatusMask", Type: "NvU32", Offset: 80},
+       s"NvU32 nvlinkMinL1Threshold",
        {
-               Name:   "remoteDeviceInfo",
+               Name:   "nvlinkMaxL1Threshold",
-               Type:   "NV2080_CTRL_NVLINK_DEVICE_INFO",
+               Type:   "NvU32",
                Offset: 88,
        },
+       s"NvU32 nvlinkL1ThresholdUnits",
        {
-               Name:   "localDeviceInfo",
+               Name:   "remoteDeviceInfo",
                Type:   "NV2080_CTRL_NVLINK_DEVICE_INFO",
-               Offset: 136,
+               Offset: 96,
        },
+       s"NV2080_CTRL_NVLINK_DEVICE_INFO localDeviceInfo",
  }

I1101 14:36:29.595784  1074191 run_differ.go:147]
--- A: /tmp/run_differ_2014218811/run_differ_3207981357/550.90.07/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080gpu.h:755:16
+++ B: /tmp/run_differ_2014218811/run_differ_1071705113/560.35.03/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080gpu.h:762:16
struct NV2080_CTRL_GPU_GET_ENGINES_V2_PARAMS
  size: 260 -> 340 (bytes)
  []parser.RecordField{
        {Name: "engineCount", Type: "NvU32"},
        {
                Name:   "engineList",
-               Type:   "NvU32[64]",
+               Type:   "NvU32[84]",
                Offset: 4,
        },
  }

I1101 14:36:29.595806  1074191 run_differ.go:147]
--- A: /tmp/run_differ_2014218811/run_differ_3207981357/550.90.07/src/common/sdk/nvidia/inc/ctrl/ctrl0080/ctrl0080gpu.h:511:16
+++ B: /tmp/run_differ_2014218811/run_differ_1071705113/560.35.03/src/common/sdk/nvidia/inc/ctrl/ctrl0080/ctrl0080gpu.h:512:16
struct NV0080_CTRL_GPU_GET_CLASSLIST_V2_PARAMS
  size: 700 -> 404 (bytes)
  []parser.RecordField{
        {Name: "numClasses", Type: "NvU32"},
        {
                Name:   "classList",
-               Type:   "NvU32[174]",
+               Type:   "NvU32[100]",
                Offset: 4,
        },
  }

I1101 14:36:29.595829  1074191 run_differ.go:147]
--- A: /tmp/run_differ_2014218811/run_differ_3207981357/550.90.07/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080bus.h:1354:16
+++ B: /tmp/run_differ_2014218811/run_differ_1071705113/560.35.03/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080bus.h:1311:16
struct NV2080_CTRL_CMD_BUS_GET_PCIE_SUPPORTED_GPU_ATOMICS_PARAMS
  size: 104 -> 112 (bytes)
  []parser.RecordField{
        {
-               Name:   "atomicOp",
+               Name:   "capType",
-               Type:   "NV2080_CTRL_CMD_BUS_GET_PCIE_SUPPORTED_GPU_ATOMICS_PARAMS::atomicOp_t[13]",
+               Type:   "NvU32",
                Offset: 0,
        },
+       s"NvU32 dbdf",
+       s"NV2080_CTRL_BUS_PCIE_GPU_ATOMIC_OP_INFO[13] atomicOp",
  }

I1101 14:36:29.595859  1074191 run_differ.go:147]
--- A: /tmp/run_differ_2014218811/run_differ_3207981357/550.90.07/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080fb.h:423:16
+++ B: /tmp/run_differ_2014218811/run_differ_1071705113/560.35.03/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080fb.h:451:16
struct NV2080_CTRL_FB_GET_INFO_V2_PARAMS
  size: 444 -> 460 (bytes)
  []parser.RecordField{
        {Name: "fbInfoListSize", Type: "NvU32"},
        {
                Name:   "fbInfoList",
-               Type:   "NV2080_CTRL_FB_INFO[55]",
+               Type:   "NV2080_CTRL_FB_INFO[57]",
                Offset: 4,
        },
  }

I1101 14:36:29.595883  1074191 run_differ.go:147]
--- A: /tmp/run_differ_2014218811/run_differ_3207981357/550.90.07/src/common/sdk/nvidia/inc/ctrl/ctrl0080/ctrl0080gpu.h:311:16
+++ B: /tmp/run_differ_2014218811/run_differ_1071705113/560.35.03/src/common/sdk/nvidia/inc/ctrl/ctrl0080/ctrl0080gpu.h:311:16
struct NV0080_CTRL_GPU_GET_VIRTUALIZATION_MODE_PARAMS
  size: 4 -> 8 (bytes)
  []parser.RecordField{
        {Name: "virtualizationMode", Type: "NvU32"},
+       s"NvBool isGridBuild",
  }

I1101 14:36:29.595910  1074191 run_differ.go:147]
--- A: /tmp/run_differ_2014218811/run_differ_3207981357/550.90.07/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080nvlink.h:399:16
+++ B: /tmp/run_differ_2014218811/run_differ_1071705113/560.35.03/src/common/sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080nvlink.h:429:16
struct NV2080_CTRL_CMD_NVLINK_GET_NVLINK_STATUS_PARAMS
  size: 5896 -> 6152 (bytes)

I1101 14:36:29.595915  1074191 run_differ.go:140] type NV2080_CTRL_CMD_BUS_GET_PCIE_SUPPORTED_GPU_ATOMICS_PARAMS::atomicOp_t not found in second source file
I1101 14:36:29.595922  1074191 run_differ.go:151] Comparing type aliases between 550.90.07 and 560.35.03
```

Fixes #11104

PiperOrigin-RevId: 692298807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exported Issue was exported automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nvproxy: Support for NVIDIA driver 560.35.03
1 participant