Implement PayloadLoad operation (parsing, interpretation, evaluation, tests). #10782
+913
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test/cl662226011
branch
2 times, most recently
from
879c9e4
to
c049504
Compare
… tests). Tests payload load evaluation for all basic fields of IP, IPv6, & TCP headers. These are the main headers that are encountered for gVisor, so their implementation was prioritized. Loading for other packet headers should work as expected since raw/general payload loading works, but it has not been explicitly tested. These tests should be added later and a TODO has been left noting this. PiperOrigin-RevId: 668202252
copybara-service
bot
force-pushed
the
test/cl662226011
branch
from
c049504
to
33dc938
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement PayloadLoad operation (parsing, interpretation, evaluation, tests).
Tests payload load evaluation for all basic fields of IP, IPv6, & TCP headers.
These are the main headers that are encountered for gVisor, so their
implementation was prioritized. Loading for other packet headers should work
as expected since raw/general payload loading works, but it has not been
explicitly tested. These tests should be added later and a TODO has been left
noting this.