-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable go module support for the project #3
Conversation
Signed-off-by: sadmansakib <ssadman8@gmail.com>
Signed-off-by: sadmansakib <ssadman8@gmail.com>
Signed-off-by: sadmansakib <ssadman8@gmail.com>
Signed-off-by: sadmansakib <ssadman8@gmail.com>
Signed-off-by: sadmansakib <ssadman8@gmail.com>
Thanks for making this initial work I already made the request to activate travis on this repo and see if we can bring it up on this PR, altough we're also thinking about using github actions; For the time being travis already provides a simple and known way to start a test matrix so there's that (we will work on the github actions on a later PR) |
There is an additional issue wrt to the go modules path. If we use |
lowered the go version to make it consistent with matrix build
Signed-off-by: sadmansakib <ssadman8@gmail.com>
Is there any discussion regarding whether this fork will start from v1.0.0 release cycle or inherit v3.x release cycle from dgrijalva/jwt-go |
I created another issue #5 here to track adding module support. But as previously mentioned, this all depends on the preference of the original maintainer (see comment here). After what happened with go-chi (go-chi/chi#561), going from pre-modules v4 to module support with v1 (reasoning explained here go-chi/chi#560) and ultimately settling on /v5 .. I'm a bit reluctant to merge this until we know the preference of the upstream repo. |
no longer needed since github actions workflow was created for the project Signed-off-by: sadmansakib <ssadman8@gmail.com>
@sadmansakib: Could you please restore the |
This reverts commit b3ae57f.
I have reverted the commit and resolved the conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thank you for your contribution.
through this series of commits i have enabled go module support by following official docs. All README files are subjected to further changes