Add ITextureProvider.ConvertToKernelTexture #2003
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lets you obtain an instance of Kernel::Texture from IDalamudTextureWrap.
goaaats
requested changes
Aug 6, 2024
| /// <param name="leaveWrapOpen">Whether to leave <paramref name="wrap"/> non-disposed when the returned | ||
| /// <see cref="Task{TResult}"/> completes.</param> | ||
| /// <returns>Address of the new <see cref="FFXIVClientStructs.FFXIV.Client.Graphics.Kernel.Texture"/>.</returns> | ||
| nint ConvertToKernelTexture(IDalamudTextureWrap wrap, bool leaveWrapOpen = false); |
There was a problem hiding this comment.
I wonder if it would be wise to write a little bit about lifecycle here? How are you supposed to use this, what happens when you call this with texture wraps from shared textures, what are you supposed to do with the texture you're replacing and do you need to do anything to what you get back here when the texture is no longer used by the game?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets you obtain an instance of Kernel::Texture from IDalamudTextureWrap.
Context: https://discord.com/channels/581875019861328007/653504487352303619/1270253907485921280
Displaying contents that is difficult to represent using game's native UI toolkit might be a common use case (eg. unsupported glyphs for various languages), so supporting displaying textures on them could be nice.