Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISIT: remove api9 compat, IDAM: make Empty4X4 transparent #1877

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

Soreepeong
Copy link
Contributor

No description provided.

@Soreepeong Soreepeong requested a review from a team as a code owner July 2, 2024 05:54
@goaaats
Copy link
Member

goaaats commented Jul 2, 2024

What are the consequences of merging this now? Have we removed all of the ways to access this legacy stuff?

@Soreepeong
Copy link
Contributor Author

The functions removed are used only for supporting API9 texture provider functions. It should be safe to remove them.

@goaaats
Copy link
Member

goaaats commented Jul 2, 2024

Perfect, thank you.

@Soreepeong Soreepeong changed the title ISIT: remove api9 compat, INM: add ISIT support ISIT: remove api9 compat, IDAM: make Empty4X4 transparent Jul 3, 2024
@Soreepeong
Copy link
Contributor Author

Since #1879 exists, ISIT support to INM is removed from this PR; instead, fixed Empty4X4 to be actually transparent.

@goaaats goaaats merged commit 7a90921 into goatcorp:master Jul 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants