Add font properties to IUiBuilder #1865
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Critical-Impact
force-pushed
the
ui-builder-fonts
branch
from
b6ca3bb
to
2e0bd38
Compare
|
Anything blocking this one? Only adds to the interface and allows for plugins to not have to rely on a static |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides properties that match the static UiBuilder counterparts. Ideally the statics should go but I've conceded that point, I understand the convience factor, though it does make for a leaky interface
For those using DI, unit tests/mocks/etc this should allow for parity