avoid misuse of Launcher.Set

go-rod · Jun 27, 2022 · 3ce5edd · 3ce5edd
1 parent 908739c
commit 3ce5edd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/lib/launcher/launcher.go b/lib/launcher/launcher.go
@@ -158,6 +158,9 @@ func (l *Launcher) Context(ctx context.Context) *Launcher {
 
 // Set a command line argument to launch the browser.
 func (l *Launcher) Set(name flags.Flag, values ...string) *Launcher {
+	if strings.Contains(string(name), "=") {
+		panic("flag name should not contain '='")
+	}
 	l.Flags[l.normalizeFlag(name)] = values
 	return l
 }

diff --git a/lib/launcher/launcher_test.go b/lib/launcher/launcher_test.go
@@ -121,6 +121,10 @@ func TestLaunch(t *testing.T) {
 		_, err = launcher.NewManaged("ws://not-exists")
 		g.Err(err)
 	}
+
+	{
+		g.Panic(func() { launcher.New().Set("a=b") })
+	}
 }
 
 func TestLaunchUserMode(t *testing.T) {