Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix translation in popup menu #926

Merged

Conversation

lexdene
Copy link
Contributor

@lexdene lexdene commented Jun 25, 2024

The texts in popup menu are not translated correctly.

The gettext function should be placed together with the original text,
or it will not be detected by ./genpot.sh.

I think this bug is introduced by #663.

@mattrose
Copy link
Member

mattrose commented Jul 3, 2024

Looks good, thanks for the fix!

@mattrose mattrose merged commit fa89055 into gnome-terminator:master Jul 3, 2024
2 checks passed
@lexdene lexdene deleted the bugfix_translation_popup_menu branch July 3, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants