Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add charset detection to decoder #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add charset detection to decoder #17

wants to merge 1 commit into from

Conversation

i39
Copy link

@i39 i39 commented Mar 24, 2017

Add charset detection for remove errors like this:
extractor.go:58: xml: encoding "windows-1251" declared but Decoder.CharsetReader is nil

@gnewton
Copy link
Owner

gnewton commented Jun 17, 2017

Hello,

Sorry to be so slow to respond.

I checked out https://github.com/i39/chidley and when I did 'go build' got these errors:

$ go build
# _/home/gnewton/tmp/g/chidley
./extractor.go:42: undefined: charset.NewReaderLabel
$

I will look at your suggested solution and see if I can implement it.

Thanks,
Glen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants