fix(user): default entity value = Full structure #18132
Open
+62
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-anne
reviewed
Oct 23, 2024
There was a problem hiding this comment.
Honestly, I am not sure to know how it is supposed to work, but I think that selecting Full structure as default entity is finally not always similar to selecting Root entity. Indeed, one may want to have only the Root entity selected by default without any recursivity.
With you proposal, the is_recursive flag defined in the glpi_profiles_users will be ignored. Maybe the solution is to make this field nullable and use the NULL value for the Full structure.
cedric-anne
reviewed
Oct 23, 2024
This reverts commit 1fa9f03.
cedric-anne
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Completely replace the 'root entity' with 'Full structure' for the user's default entity selection (feature: #17923). This is to handle the case where a user has multiple permissions for the same profile, including one for the root entity that is non-recursive.