-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template Cloning #18103
base: main
Are you sure you want to change the base?
Template Cloning #18103
Conversation
fc12550
to
4f579df
Compare
4358d50
to
bbc4e8e
Compare
c3ba184
to
b4cb1fd
Compare
@@ -226,7 +227,7 @@ public function cloneMultiple( | |||
* | |||
* @return false|integer The new ID of the clone (or false if fail) | |||
*/ | |||
public function clone(array $override_input = [], bool $history = true) | |||
public function clone(array $override_input = [], bool $history = true, bool $clone_as_template = false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add phpdoc for new param
@@ -194,15 +194,16 @@ public function prepareInputForClone($input) | |||
public function cloneMultiple( | |||
int $n, | |||
array $override_input = [], | |||
bool $history = true | |||
bool $history = true, | |||
bool $clone_as_template = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add phpdoc for new param
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested UI part, API not tested.
Checklist before requesting a review
Description
Proper implementation of what was blocked in #17775 (v10.0.17) to prevent undefined behavior.