Template Cloning #18103
Open
Template Cloning #18103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cconard96
force-pushed
the
feature/template_cloning
branch
from
fc12550
to
4f579df
Compare
cconard96
force-pushed
the
feature/template_cloning
branch
from
4358d50
to
bbc4e8e
Compare
cconard96
force-pushed
the
feature/template_cloning
branch
from
c3ba184
to
b4cb1fd
Compare
trasher
reviewed
Oct 22, 2024
| @@ -226,7 +227,7 @@ public function cloneMultiple( | |||
| * | |||
| * @return false|integer The new ID of the clone (or false if fail) | |||
| */ | |||
| public function clone(array $override_input = [], bool $history = true) | |||
| public function clone(array $override_input = [], bool $history = true, bool $clone_as_template = false) | |||
There was a problem hiding this comment.
Please add phpdoc for new param
trasher
reviewed
Oct 22, 2024
| @@ -194,15 +194,16 @@ public function prepareInputForClone($input) | |||
| public function cloneMultiple( | |||
| int $n, | |||
| array $override_input = [], | |||
| bool $history = true | |||
| bool $history = true, | |||
| bool $clone_as_template = false | |||
There was a problem hiding this comment.
Please add phpdoc for new param
trasher
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
Proper implementation of what was blocked in #17775 (v10.0.17) to prevent undefined behavior.