This repository has been archived by the owner on Nov 14, 2019. It is now read-only.
Support backend of opentsdb #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,6 +13,7 @@ all: default | |||
| SOURCES = \ | |||
| src/backend.c \ | |||
| src/backends/carbon.c \ | |||
| src/backends/opentsdb.c \ | |||
There was a problem hiding this comment.
Not sure if github is deceiving me, but seems to be like you have a tabs vs spaces issue here and below in the enum.
|
+1 |
|
You can support opentsdb's tag by allowing application to encode it via key, see https://github.com/danslimmon/statsd-opentsdb-backend#configuration |
|
Looks pretty good. Let me backport this to our internal fork and I'll push it back. 👌 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title.