Make mapbrowse working #2010
Draft
Make mapbrowse working #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kencho51
force-pushed
the
make-mapbrowse-working
branch
from
8bf7448
to
8744be5
Compare
kencho51
force-pushed
the
make-mapbrowse-working
branch
from
29a4dfc
to
d26279f
Compare
|
Close as implemented in #1977 |
|
As discussed to better separate from #1977, so reopen this PR |
This reverts commit e4805bd.
kencho51
force-pushed
the
make-mapbrowse-working
branch
from
0a0ab5b
to
06ed18a
Compare
only1chunts
reviewed
Oct 10, 2024
There was a problem hiding this comment.
I have no idea what I'm looking at here, but "http://penguin.genomics.cn" is no longer in use so probably shouldn't appear anywhere. Also is "http://gigadb.org" correct? shouldn't have the S in it now?e.g. httpS://gigadb.org
There was a problem hiding this comment.
Hi @only1chunts,
Thanks for that, "http://penguin.genomics.cn/" has been removed and https://gigadb.org has been updated.
kencho51
force-pushed
the
make-mapbrowse-working
branch
from
d2dd738
to
8bbb614
Compare
kencho51
force-pushed
the
make-mapbrowse-working
branch
from
ee9ad85
to
a707738
Compare
|
Close as implemented in #1977 again |
|
Better implement the fix as a separate PR, so re-open this PR again |
kencho51
force-pushed
the
make-mapbrowse-working
branch
2 times, most recently
from
749eab1
to
a707738
Compare
kencho51
force-pushed
the
make-mapbrowse-working
branch
from
dfbd174
to
1351065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue: #1944
This is a pull request for the following functionalities:
How to test?
Describe how the new functionalities can be tested by PR reviewers
How have functionalities been implemented?
Describe how the new functionalities have been implemented by the
changed code at a high level
Any issues with implementation?
Describe any problems with your implementation
Any changes to automated tests?
Describe any automated tests that have been developed for the new
functionalities
Any changes to documentation?
Describe changes to the documentation
Any technical debt repayment?
Describe changes to code that repays any technical debt
Any improvements to CI/CD pipeline?
Describe any improvements to the Gitlab pipeline