ref(eap) Remove old attributes tables #6375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original meta attribute tables were replaced with slightly different versions. Remove the old tables.
|
isn't this in migration 5 already? |
volokluev
reviewed
Oct 2, 2024
| ), | ||
| ] | ||
|
|
||
| def backwards_ops(self) -> Sequence[SqlOperation]: |
There was a problem hiding this comment.
we probably shouldn't have a backwards ops. We don't want to try and recreate this table if the migration fails
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
|
This PR has a migration; here is the generated SQL -- start migrations
-- forward migration events_analytics_platform : 0016_remove_old_span_attribute_table
Local op: DROP TABLE IF EXISTS spans_attributes_meta_local;
Distributed op: DROP TABLE IF EXISTS spans_attributes_meta_dist;
-- end forward migration events_analytics_platform : 0016_remove_old_span_attribute_table
-- backward migration events_analytics_platform : 0016_remove_old_span_attribute_table
-- end backward migration events_analytics_platform : 0016_remove_old_span_attribute_table |
colin-sentry
approved these changes
Oct 2, 2024
When an escape character is used in a string, Python 3.12 will now show a SyntaxWarning. See here: https://docs.python.org/dev/whatsnew/3.12.html#other-language-changes This was causing mypy to fail to run. Fix this bug across the codebase. Also exclude the rust_snuba files (which suffer from this problem) since they are autogenerated.
This reverts commit a561c8f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original meta attribute tables were replaced with slightly different versions.
Remove the old tables.