Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Flutter from 3.10.0 to 3.13.0 in docker image #543

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Jun 17, 2024

Currently Flutter 3.10.0 is packaged with Dart 3.0.0.
Now we require Dart 3.1.0 which is packaged starting with Flutter 3.13.0

See: https://github.com/getsentry/publish/actions/runs/9548988953/job/26317502315#step:11:104

Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please in the future request reviews from team-dev-infra instead!

@@ -78,7 +78,7 @@ RUN : \
&& chmod +x /usr/local/bin/SymbolCollector.Console

# https://docs.flutter.dev/get-started/install/linux#install-flutter-manually
RUN curl -fsSL https://storage.googleapis.com/flutter_infra_release/releases/stable/linux/flutter_linux_3.10.0-stable.tar.xz -o /opt/flutter.tar.xz \
RUN curl -fsSL https://storage.googleapis.com/flutter_infra_release/releases/stable/linux/flutter_linux_3.13.0-stable.tar.xz -o /opt/flutter.tar.xz \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably be checksumming this file to ensure it is what we expected though nothing else does that here so shrugs

@buenaflor
Copy link
Contributor Author

please in the future request reviews from team-dev-infra instead!

ah sry, thx for the quick approve though

@buenaflor buenaflor merged commit eabf2f8 into master Jun 17, 2024
8 checks passed
@buenaflor buenaflor deleted the chore/upgrade-flutter-3.13.0 branch June 17, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants