fix: add hostname check to decide http mode in windows #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im-adithya
force-pushed
the
task-node-bkp
branch
from
e23ac7f
to
ead2439
Compare
im-adithya
force-pushed
the
task-node-bkp
branch
from
ead2439
to
91fdbd2
Compare
im-adithya
changed the title
|
good debugging. |
rolznz
reviewed
Oct 17, 2024
| @@ -8,7 +8,9 @@ type Props = { | |||
| }; | |||
|
|
|||
| export default function ExternalLink({ to, className, children }: Props) { | |||
| const isHttpMode = window.location.protocol.startsWith("http"); | |||
| const isHttpMode = | |||
There was a problem hiding this comment.
can we extract this check now?
There was a problem hiding this comment.
Yeah best to do that, but where should this live? frontend/src/utils/ishttpmode.ts?
There was a problem hiding this comment.
Actually, I'm not sure we should do this and actually just use a NSIS installer, if that is not much extra work
There was a problem hiding this comment.
We decided to keep as-is. Since the check is more complicated now I think extracting it into frontend/src/utils/isHttpMode.ts would be good.
And we said we might want to do a hotfix. I will make a new milestone for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unlike Linux and Darwin, Windows doesn't allow wails:// protocol without having NSIS installer. So wails uses http://wails.localhost in Windows. This leads to the HTTP backup endpoint being requested in Windows which results in
405 Method Not Allowed