App child key derived from wallet master key #736
Conversation
frnandu
changed the title
| scopes []string, | ||
| isolated bool, | ||
| metadata map[string]interface{}, | ||
| walletChildPrivKeyGeneratorFunc func(appId uint32) (string, error), |
There was a problem hiding this comment.
Minor: rather than passing this method as an argument, the keys could be passed to the db_service in the NewDBService function
There was a problem hiding this comment.
I tried that but get:
package command-line-arguments
imports github.com/getAlby/hub/http
imports github.com/getAlby/hub/alby
imports github.com/getAlby/hub/config
imports github.com/getAlby/hub/db
imports github.com/getAlby/hub/service/keys
imports github.com/getAlby/hub/config: import cycle not allowed
Is is possible to easily fix this import cycle without too much refactoring?
There was a problem hiding this comment.
This might be fixed in #710 which I move the app management out of the db package. This will cause some conflicts here when it's merged, which I can then resolve.
service/start.go
Outdated
|
|
||
| func (svc *service) startAllExistingAppsWalletSubscriptions(ctx context.Context, relay *nostr.Relay) { | ||
| var apps []db.App | ||
| result := svc.db.Where("wallet_child_pubkey != ?", "").Find(&apps) |
There was a problem hiding this comment.
is this query correct, shouldn't it be wallet_child_pubkey IS NOT NIL?
There was a problem hiding this comment.
I'm actually not sure, because if for some reason an app DB row is created but then it fails to update the column with the calculated pubkey it will have an empty string '' as value, which the current query filters, and IS NOT NULL does not.
Is there a way to make sure that when a new DB row is created without passing a value to that column it will have NULL value instead of ''?
There was a problem hiding this comment.
Ah, gorm uses the default value of the column type. If it was a *string instead of a string it would work. But maybe we will ensure all the apps have keys, so this is no longer an issue.
frnandu
changed the title
fixes #724