Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate wallet key for each connection #724

Open
frnandu opened this issue Oct 4, 2024 · 1 comment · May be fixed by #736
Open

Separate wallet key for each connection #724

frnandu opened this issue Oct 4, 2024 · 1 comment · May be fixed by #736
Milestone

Comments

@frnandu
Copy link
Contributor

frnandu commented Oct 4, 2024

This will allow better privacy between connections, which currently can see metadata from events of other connections since it uses the same wallet key.

@rolznz rolznz added this to the v1.11.0 milestone Oct 5, 2024
@frnandu
Copy link
Contributor Author

frnandu commented Oct 11, 2024

Some considerations:

  • Currently the single wallet key is kept in DB encrypted and when hub starts and is unlocked with password it is decrypted and that private key is kept in memory, so that when needed for signing events with wallet priv key it is accessible.
  • If we would want to have a separate wallet key for each connection, we would need to keep each wallet private key in App model in DB, ideally encrypted so that if db leaks it will not be a problem.
  • In order to be able to encrypt a new wallet private key each time a new connection is created we would need the unlock password so that we can encrypt the new wallet private key and write it to the DB encrypted.
  • AFAIK unlock password is not (and should not be) kept in memory, so this presents a problem.
  • Should we write wallet private keys for each connection in App DB model unencrypted???
  • Any other ideas how to implement this in a secure manner?
    @rolznz @bumi @reneaaron @im-adithya

@frnandu frnandu linked a pull request Oct 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants