Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set rewrite location as in request #108

Closed
wants to merge 1 commit into from
Closed

Set rewrite location as in request #108

wants to merge 1 commit into from

Conversation

f-necas
Copy link
Collaborator

@f-necas f-necas commented Mar 5, 2024

In order to solve issues mentionned in #104, this option allows redirections to work correctly and to keep tests working.

Also closes : #105

@pmauduit
Copy link
Member

pmauduit commented Mar 5, 2024

I am confused: so it was only the redirect responses that were causing trouble in #104 ?

@f-necas
Copy link
Collaborator Author

f-necas commented Mar 5, 2024

As I understand, yes.
But I caught a new error with this solution.

When setting a route like :

      - id: root
        uri: ${georchestra.gateway.services.my.target}
        predicates:
        - Path=/
        filters:
        - RedirectTo=308, /my/home

It ends up with a :

Error starting response. Replying er │
│                                                                                                                                                                                                   │
│ java.lang.UnsupportedOperationException: null                                                                                                                                                     │
│     at org.springframework.http.ReadOnlyHttpHeaders.set(ReadOnlyHttpHeaders.java:106) ~[spring-web-5.3.27.jar:5.3.27]                                                                             │
│     Suppressed: reactor.core.publisher.FluxOnAssembly$OnAssemblyException

@f-necas f-necas marked this pull request as draft March 5, 2024 14:20
@f-necas f-necas closed this Apr 9, 2024
@f-necas f-necas deleted the rewrite-location branch April 9, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants