fix broken tests (2)

georchestra · Mar 8, 2024 · b683156 · b683156
1 parent fc73b31
commit b683156
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/...a/org/georchestra/gateway/filter/headers/providers/GeorchestraUserHeadersContributor.java b/...a/org/georchestra/gateway/filter/headers/providers/GeorchestraUserHeadersContributor.java
@@ -65,7 +65,7 @@ public class GeorchestraUserHeadersContributor extends HeaderContributor {
  add(headers, SEC_LDAP_REMAINING_DAYS, Optional
  .of(user.isPresent() && user.get().getLdapWarn() != null && user.get().getLdapWarn()),
  user.map(GeorchestraUser::getLdapRemainingDays));
- add(headers, SEC_EXTERNAL_AUTHENTICATION, Optional.of(true),
+ add(headers, SEC_EXTERNAL_AUTHENTICATION, Optional.of(user.isPresent()),
  String.valueOf(user.isPresent() && user.get().getIsExternalAuth()));
  });
  };

diff --git a/...g/georchestra/gateway/filter/headers/providers/GeorchestraUserHeadersContributorTest.java b/...g/georchestra/gateway/filter/headers/providers/GeorchestraUserHeadersContributorTest.java
@@ -23,14 +23,12 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
-import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.Objects;
 import java.util.function.Consumer;
 import java.util.stream.Collectors;
 
@@ -88,10 +86,7 @@ void testNoUser() {
 
  HttpHeaders target = new HttpHeaders();
  contributor.accept(target);
- assertFalse(target.isEmpty());
- Objects.requireNonNull(target.get(SEC_EXTERNAL_AUTHENTICATION));
- assertEquals(List.of("false"), target.get(SEC_EXTERNAL_AUTHENTICATION));
- assertEquals(1, target.size());
+ assertTrue(target.isEmpty());
  }
 
  @Test