PB-987: Add item-search to conformance endpoint #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansmannj
reviewed
Oct 14, 2024
| def add_landing_page_version(apps, schema_editor): | ||
| LandingPage = apps.get_model("stac_api", "LandingPage") | ||
| lp = LandingPage.objects.get(version='v1') | ||
| lp.conformsTo.insert(2, 'https://api.stacspec.org/v1.0.0/item-search') |
There was a problem hiding this comment.
Would we also need to add conformance to https://api.stacspec.org/v1.0.0/collections/?
benschs
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
If I remember correctly we don't fully comply with the "item-search".
We use content-type header application/json instead of application/geo+json, this is to optimize cloudfront.
If we don't care about this we could probably also add "https://api.stacspec.org/v1.0.0/ogcapi-features".
I found https://github.com/stac-utils/stac-api-validator useful to help test our conformance.
LukasJoss
force-pushed
the
feat-PB-987-adapt-conformance-endpoint
branch
from
66048ef
to
68e484e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.