fix: functions were modifying input options object #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The externally-facing looks-same functions were mutating any
options
object passed into them.This was problematic because if you wanted to reuse an options object for multiple calls, it would cause failure. For example, if you had an options object that simply had
{strict: true}
, then during the first call, looks-same would add athreshold
property to that, and then complain about the presence of bothstrict
andthreshold
on the second call.This PR adds tests to ensure that the options objects are not mutated, and applies two types of fix:
_.defaults
mutates its first parameter, so add an extra empty{}
as the initial parameter. This way, we accumulate the results in a new object. (It would be even simpler to use an object spread but I don't see any in this codebase and it might cause compatibility issues.)opts
, but combine that defaulting with._defaults
calls.This fixes issue #41