Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make optional args keyword-only #1134

Merged
merged 8 commits into from
Feb 18, 2024
Merged

make optional args keyword-only #1134

merged 8 commits into from
Feb 18, 2024

Conversation

gboeing
Copy link
Owner

@gboeing gboeing commented Feb 17, 2024

This PR:

  • makes optional function parameters keyword-only throughout package
  • makes dist function parameters required rather than optional throughout package
  • renames truncate.truncate_graph_dist's max_dist argument to dist for consistency
  • removes unnecessary check_remark param from _http._retrieve_from_cache function

See also #1106

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3491c1) 97.94% compared to head (65d2bf6) 97.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #1134      +/-   ##
==========================================
- Coverage   97.94%   97.93%   -0.01%     
==========================================
  Files          25       25              
  Lines        2428     2427       -1     
==========================================
- Hits         2378     2377       -1     
  Misses         50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gboeing gboeing merged commit fc4837e into v2 Feb 18, 2024
7 checks passed
@gboeing gboeing deleted the args branch February 18, 2024 06:34
@gboeing gboeing mentioned this pull request Feb 18, 2024
13 tasks
@gboeing
Copy link
Owner Author

gboeing commented May 3, 2024

The first pre-release OSMnx v2 beta has been released. Testers needed! See #1123 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant