New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use session_id at SimpleCaptcha::Utils::generate_key() #32

Open

nakajijapan wants to merge 1 commit into galetahub:master from nakajijapan:use-session_id-at-generate_key-method

nakajijapan commented Feb 1, 2013

It is wasteful not to use this code at default.

      def simple_captcha_key(key_name = nil)
        if key_name.nil?
          session[:captcha] ||= SimpleCaptcha::Utils.generate_key(session[:id].to_s, 'captcha')
        else
          SimpleCaptcha::Utils.generate_key(session[:id].to_s, key_name)
        end
      end

I want to change session[:id] into session[:session_id].
Then, we can use session_id at default and simple_capthca_data.key become more unique.


          use session_id at SimpleCaptcha::Utils::generate_key()

5d90319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet