refactor!: Rename Api to OwnerApi. Remove ResponseData<T>. Add VehicleApi trait. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eApi trait. Significant refactor to progress towards different API access that Tesla has introduced. See issues #6 and #7. Removed `ResponseData` because it wasn't very ergonomic, forcing the user to deref or call data(). Also it had specific fields for JSON output which was only used for the CLI, so I introduced a field `print_responses` in OwnerApi that the CLI can use.
|
I'm trying to make these changes as gradual as possible.
@ulrichard FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significant refactor to progress towards different API access that Tesla
has introduced. See issues #6 and #7.
Removed
ResponseDatabecause it wasn't very ergonomic, forcing the userto deref or call data(). Also it had specific fields for JSON output
which was only used for the CLI, so I introduced a field
print_responsesin OwnerApi that the CLI can use.