Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paket.targets -> Paket.Restore.targets #3604

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbeeko
Copy link
Contributor

@jbeeko jbeeko commented Jun 30, 2019

I believe the docs are out of date on this file. I don't have a paket.targets file, only a Packet.Restore.targets file. Updated the docs on the assumption Paket.Restore.targets is the new name.

Pls review my comment on the implications of not committing this file as I'm not sure that is correct.

I believe the docs are out of date on this file. I don't have a paket.targets file, only a Packet.Restore.targets file. Updated the docs on the assumption Paket.Restore.targets is the new name.

Pls review my comment on the implications of not committing this file as I'm not sure that is correct.
@matthid
Copy link
Member

matthid commented Jun 30, 2019

Afaik, paket.targets is for "legacy" projects while Paket.Restore.targets is for new SDK style projects.
So paket.targets is indeed becoming more and more legacy.

@jbeeko
Copy link
Contributor Author

jbeeko commented Jun 30, 2019

@matthid Thank you for clarifying. So I should update the FAQ to note that paket.targets is for the legacy projects and add an entry for Paket.Restore.targets. I assume the same comments apply, commit Paket.Restore.targets to get auto-restore in Visual Studio.

@JohnyWS
Copy link
Contributor

JohnyWS commented Nov 15, 2019

@matthid can the target file be avoided entirely? Then how are references even resolved? Isn't that trough the target file? At least that's my impression in the new SDK format?

@matthid
Copy link
Member

matthid commented Nov 15, 2019

@JohnyWS there are two of them

@JohnyWS
Copy link
Contributor

JohnyWS commented Nov 16, 2019

@matthid I'm not sure I get it. I just tried the following:

Project A is old csproj format. Cloned it as Project B and changed it to SDK format. Installed paket in both. Lastly, I called "paket auto-restore off" on both.

This results in Project A having no target file, but Project B still has "Paket.Restore.targets" file, as well as auto-restore.

So in the new SDK format, how is it supposed to work? If "Paket.Restore.targets" is gone, there is now targets file left, and if now, how are the NuGet references supposed to work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants