Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a FS3548 'Pattern discard is not allowed for union case that takes no data.' compiler warning #2824

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Sep 16, 2024

Description

ToolType.FullFramework has no payload, so it shouldn't need the discard

@Numpsy
Copy link
Contributor Author

Numpsy commented Sep 16, 2024

refs

image

@xperiandri xperiandri changed the title Fix a FS3548 'Pattern discard is not allowed for union case that take… Fix a FS3548 'Pattern discard is not allowed for union case that takes no data.' compiler warning Sep 16, 2024
@Thorium
Copy link
Member

Thorium commented Sep 21, 2024

Mac build is still unstable. The message which Mac build fails make no sense to this PR.
It's even hard to reason about what it fails to,
no dependencies hello world and casing #2314 failed so it should do "dotnet fake" for very simple file. Seems to work in my MacBook (old Intel).

@Numpsy
Copy link
Contributor Author

Numpsy commented Sep 21, 2024

I put some observations about the macOS CI failures in #2814, but I don't know if it's just a timing issue or something else (it doesn't seem to happen on the Windows or Linux riuns though)

@xperiandri xperiandri merged commit 9404e21 into fsprojects:master Sep 22, 2024
3 checks passed
@Numpsy Numpsy deleted the discard branch September 22, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants