Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GenerateReleaseNotes support to GitHub #2751

Conversation

raymens
Copy link
Contributor

@raymens raymens commented Jun 7, 2023

Description

Add an option for the GitHub Create Release step to enable generating of release notes.
Had to update the Octokit package for it.

I noticed some differences between the (new?) GitHub API and how the package is structured in FAKE.
For example that currently the name of the release always equals the tagname for FAKE while these are different in GitHub.
However I didn't want to necessarily take that on in this PR.

I did not find any docs or tests I would need to update.

TODO

Feel free to open the PR and ask for help

  • unit or integration test exists (or short reasoning why it doesn't make sense)
  • boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)
  • Fake API guideline is honored

@raymens raymens marked this pull request as ready for review June 7, 2023 20:29
@raymens raymens force-pushed the expand-github-support-generate-releasenotes branch from 7bfa94d to 302669d Compare June 7, 2023 20:31
@xperiandri xperiandri force-pushed the expand-github-support-generate-releasenotes branch from 302669d to a9b525b Compare October 1, 2023 13:30
@xperiandri
Copy link
Collaborator

Approved, thank you very much for the contribution!

@xperiandri xperiandri force-pushed the expand-github-support-generate-releasenotes branch from a9b525b to 173d96f Compare October 29, 2023 18:17
@xperiandri
Copy link
Collaborator

@raymens can you rebase? Or invite to your repo, I'll rebase myself

@raymens raymens force-pushed the expand-github-support-generate-releasenotes branch from df56cb8 to 00762a4 Compare October 30, 2023 08:24
@raymens
Copy link
Contributor Author

raymens commented Oct 30, 2023

@xperiandri I've rebased the solution

@xperiandri xperiandri force-pushed the expand-github-support-generate-releasenotes branch from 00762a4 to 40fe48f Compare December 11, 2023 19:32
@xperiandri xperiandri merged commit 5c064f2 into fsprojects:master Dec 11, 2023
3 checks passed
@raymens raymens deleted the expand-github-support-generate-releasenotes branch December 12, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants