Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cordova indents with new clean html option #2341

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Cordova indents with new clean html option #2341

wants to merge 1 commit into from

Conversation

thewheat
Copy link
Contributor

Fixes #1004

  • Did this by adding a new option in CleanHtmlFilter and setting it in the Cordova scraper
  • The indents are removed as they are a non breaking space character that gets removed by CleanHtmlFilter. The option allows bypassing the whitespace removal if it detects a non breaking space
  • I'm open to other ways of doing this more cleanly

Existing unindented with new indented
image

Source indented with new indented
image

@thewheat thewheat requested a review from a team as a code owner October 14, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cordova: Indentation Problem
1 participant
@thewheat