Add -c argument to target-shell

[cecinestpasunepipe]

(DIS-150)

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.40%. Comparing base (d0eba16) to head (3bb3a81).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
dissect/target/tools/shell.py	66.66%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #873      +/-   ##
==========================================
- Coverage   76.41%   76.40%   -0.01%     
==========================================
  Files         314      314              
  Lines       26918    26927       +9     
==========================================
+ Hits        20569    20574       +5     
- Misses       6349     6353       +4     

Flag	Coverage Δ
unittests	76.40% <66.66%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[twiggler]

Be advised: RegistryCli also supports a targetrc file.

JSCU advised to move the loadtargetrc method to ExtendedCmd.

Originally, I wanted to trigger the execution in ExtendedCmd::__init__, but this causes an initialization fiasco because:

1. the current directory needs to be set before the targetrc file is run
2. but the directory can only be set after ExtendedCmd has initialized.

So now I trigger targetrc execution in the preloop, but I can see that this is suboptimal with regard to one-shotting.

Might also be related to the fact that we are reusing code through inheritance.

[twiggler]

Addendum: Since bash does not execute the run commands file for non-interactive shells, you can skip loading the targetrc file, until someone complaints. (discussed with @pyrco)

[cecinestpasunepipe]

So this means, this PR does not have to wait for targetrc and does not have to integrate with targetrc?

[twiggler]

Yes.

[twiggler]

QA'OK.

Code looks good.

Waiting on targetrc merge...