Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for targetrc file to execute commands when a target shell is spawned #859

Merged
merged 8 commits into from
Oct 7, 2024
Merged

Add support for targetrc file to execute commands when a target shell is spawned #859

merged 8 commits into from
Oct 7, 2024

Commits on Oct 7, 2024

  1. Add loading and executtion of rc file on cli init

    @twiggler
    twiggler committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a434c19 View commit details
    Browse the repository at this point in the history

  2. Add test to check if .targetrc file is processed

    @twiggler
    twiggler committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a06173a View commit details
    Browse the repository at this point in the history

  3. Refactor to make run commands file path a local variable. 

    This avoids unnecessary state in the TargetCLI class
    @twiggler
    twiggler committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    386eacb View commit details
    Browse the repository at this point in the history

  4. Make method for loading rc file private 

    This prevents polution of the TargetCli interface.
    @twiggler
    twiggler committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    607a1a4 View commit details
    Browse the repository at this point in the history

  5. Support loading of runcommand files in registry shell

    @twiggler
    twiggler committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d0e3cf2 View commit details
    Browse the repository at this point in the history

  6. Enhance abstraction by moving targetrc constant to subclass

    @twiggler
    twiggler committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    754b57e View commit details
    Browse the repository at this point in the history

  7. Rename constants

    @twiggler
    twiggler committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    afc3150 View commit details
    Browse the repository at this point in the history

  8. Use union syntax instead of optional

    @twiggler
    twiggler committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    5b96b70 View commit details
    Browse the repository at this point in the history