[MNT] - Plot & report tweaks #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomDonoghue
changed the title
ryanhammonds
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of minor updates to plotting and styling.
One goal is to reduce the number of warnings that are popping up - in particular around applying tight_layout, and the warnings that became more common saying "this figure can't have that". In doing so, it tweaks how plot style functions get applied (allowing for passing in None's to turn them off). It also updates how styling gets applied to group report plots, as the previous approach had issues with the twinned axes (would only get one of them, leading to different label sizes).
In part, this relates to at some point, something external seeming to have changed in terms of interpreting the figure sizes, such that our figures now seem to be printed bigger (?). This seems to be version specific - the current PR tweaks sizes to look better for me on py3.8 (in notebooks), whereas running on py36, they now look a little small...
In terms of review - code updates are fairly minor, but it would be nice for people to check that running this branch leads to to figures that look good (hopefully a bit better than before), and that there are no / fewer warnings.
Also - this is my final anticipated update for 1.1! After this, I have nothing else, and can think about tagging final 1.1