Skip to content

Commit

Permalink
chore: add contributing guide
Browse files Browse the repository at this point in the history
  • Loading branch information
psanders committed Dec 4, 2023
1 parent 3fb832c commit 89e90b9
Show file tree
Hide file tree
Showing 4 changed files with 120 additions and 22 deletions.
20 changes: 1 addition & 19 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,3 @@
# How to contribute

There are a few guidelines that we need contributors to follow so that we can have a chance of keeping on
top of things.

## Getting Started

* Fork the repository
* Add a test for your change. Only refactoring and documentation changes require no new tests. If you are adding
functionality or fixing a bug, we need a test!
* Run the tests. We only take pull requests with passing tests

## Submitting Changes

* Push your changes to your fork
* Submit a pull request

# Additional Resources

* [General GitHub documentation](http://help.github.com/)
* [GitHub pull request documentation](http://help.github.com/send-pull-requests/)
To learn how to contribute to this project, please visit our [documentation](https://routr.io/docs/2.0.0/contributing) site.
2 changes: 1 addition & 1 deletion docs/docs/community.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

We are developing Routr in the open. These are the channels we use for communication and contribution:

- [Discord community](https://discord.com/invite/mpWSRUhG7e)
- [Discord community](https://discord.com/invite/4QWgSz4hTC)
- [GitHub discussions](https://github.com/fonoster/routr/discussions)

**Twitter:** [@Fonoster](https://twitter.com/fonoster)
Expand Down
119 changes: 117 additions & 2 deletions docs/docs/contributing.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,118 @@
# Contributing
# Contributing guide

Coming soon.
* [New Contributor Guide](#contributing-guide)
* [Ways to contribute](#ways-to-contribute)
* [Find an issue](#find-an-issue)
* [Ask for help](#ask-for-help)
* [Pull request lifecycle](#pull-request-lifecycle)
* [Development environment setup](#development-environment-setup)
* [Sign your commits](#sign-your-commits)
* [Pull request checklist](#pull-request-checklist)

Welcome! We are glad that you want to contribute to our project! 💖

As you get started, you are in the best position to give us feedback on areas of our project that we need help with including:

* Problems found during setting up a new developer environment
* Gaps in our Quickstart Guide or documentation
* Bugs in our automation scripts

If anything doesn't make sense, or doesn't work when you run it, please open a bug report and let us know!

## Ways to contribute

We welcome many different types of contributions including:

* New features
* Builds, CI/CD
* Bug fixes
* Documentation
* Issue Triage
* Answering questions on Discord/GitHub Discussions
* Web design
* UI/UX
* Communications / Social Media / Blog Posts
* Release management

Not everything happens through a GitHub pull request. Please come to our [meetings](https://discord.gg/4QWgSz4hTC) or [contact us](https://discord.gg/4QWgSz4hTC) and let's discuss how we can work
together.

### Come to meetings

Absolutely everyone is welcome to come to any of our meetings. You never need an invite to join us. In fact, we want you to join us, even if you don’t have anything you feel like you want to contribute. Just being there is enough!

You can find out more about our meetings [here](https://discord.gg/4QWgSz4hTC). You don’t have to turn on your video. The first time you come, introducing yourself is more than enough.

Over time, we hope that you feel comfortable voicing your opinions, giving feedback on others' ideas, and even sharing your own ideas, and experiences.

## Find an issue

We have good first issues for new contributors and help wanted issues suitable for any contributor. [good first issue](https://github.com/fonoster/routr/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22) has extra information to help you make your first contribution. [help wanted](https://github.com/fonoster/routr/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22) are issues suitable for someone who isn't a core maintainer and is good to move onto after your first pull request.

Sometimes there won’t be any issues with these labels. That’s ok! There is likely still something for you to work on. If you want to contribute but you don’t know where to start or can't find a suitable issue, you can reach out to us via [Discord](https://discord.gg/4QWgSz4hTC) or [GitHub Discussions](https://github.com/fonoster/routr/discussions) and we will help you find something.

Once you see an issue that you'd like to work on, please post a comment saying that you want to work on it. Something like "I want to work on this" is fine.

## Ask for help

The best way to reach us with a question when contributing is to ask on:

* The original github issue
* The [Discord](https://discord.gg/4QWgSz4hTC) community
* Our [GitHub Discussions](https://github.com/fonoster/routr/discussions)

## Pull request lifecycle

Before you start, ensure no one else is working on the same issue. If a related pull request exists, consider offering your assistance there. If you don't receive a response within a reasonable timeframe, you can proceed with your own pull request.

After you've submitted your pull request, it enters the review stage. During this time, the project maintainers or contributors will examine your changes. They might request modifications, such as:

- Enhancements in your code
- Additional tests or updates to the documentation
- Changes in your implementation approach
- Dividing your pull request into smaller, more manageable parts

Depending on the project’s roadmap and priorities, you might also be asked to:

- Delay the integration of your pull request to align with future releases
- Close your current pull request and, if needed, open a new one with revised changes

## Development environment setup

See our [Development environment setup](https://routr.io/docs/2.0.0/development/introduction) guide to get started locally or using Gitpod.

## Sign your commits

### DCO

Licensing is important to open source projects. It provides some assurances that the software will continue to be available based under the terms that the author(s) desired. We require that contributors sign off on commits submitted to our project's repositories. The [Developer Certificate of Origin (DCO)](https://probot.github.io/apps/dco/) is a way to certify that you wrote and have the right to contribute the code you are submitting to the project.

You sign-off by adding the following to your commit messages. Your sign-off must match the git user and email associated with the commit.

```text
This is my commit message
Signed-off-by: Your Name <your.name@example.com>
```

Git has a `-s` command line option to do this automatically:

```text
git commit -s -m 'This is my commit message'
```

If you forgot to do this and have not yet pushed your changes to the remote repository, you can amend your commit with the sign-off by running

```text
git commit --amend -s
```

## Pull request checklist

When you submit your pull request, or you push new commits to it, our automated systems will run some checks on your new code. We require that your pull request passes these checks, but we also have more criteria than just that before we can accept and merge it. We recommend that you check the following things locally before you submit your code:

- [ ] Your code builds and passes tests locally
- [ ] Your code passes our automated checks
- [ ] You have signed your commits
- [ ] You have added tests for your code (if applicable)
- [ ] You have updated the documentation (if applicable)
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"start:edgeport": "cross-env NODE_ENV=dev LOGS_LEVEL=verbose ./mods/edgeport/edgeport.sh",
"start:requester": "cross-env NODE_ENV=dev LOGS_LEVEL=verbose ./mods/requester/requester.sh",
"start:rtprelay": "cross-env NODE_ENV=dev LOGS_LEVEL=verbose nodemon mods/rtprelay/src/runner",
"start:docs": "cd docs && npm start",
"rtpengine:up": "docker-compose -f docker-compose.dev.yml up rtpengine -d",
"redis:up": "docker-compose -f docker-compose.dev.yml up redis -d",
"db:up": "docker-compose -f docker-compose.dev.yml up postgres adminer -d",
Expand Down

0 comments on commit 89e90b9

Please sign in to comment.