Test_data added for #4764 #1764
Open
+296
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Signed-off-by: 10sharmashivam <10sharmashivam@gmail.com>
10sharmashivam
force-pushed
the
po_tests_broken
branch
from
02067ac
to
c4003df
Compare
eapolinario
reviewed
Oct 23, 2024
Signed-off-by: 10sharmashivam <10sharmashivam@gmail.com>
|
@10sharmashivam this is great! does the example work for you in your local cluster? |
Hi @davidmirror-ops! Yes, the example worked correctly for me. I temporarily hosted the biostats.csv file using a local HTTP server, which allowed me to access the CSV file via a localhost URL. I used this URL as the csv_url input to test the CSV normalization, addressing the issue with the broken external link in the parent issue. It produced the expected output—a normalized CSV file—so everything worked perfectly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Reference Issue
Reference PR - In which adding .csv files allowed
Why are the changes needed?
These changes help and keep test_data on flyteorg/flytesnacks repo, which can work as internal source for test data
Once this PR is approved and merged, I will use the raw github user content link of these test data, and use to correct the broken tests.