Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-648 flytesnacks edits needed for Neptune and W&B flytekit plugins documentation #1748

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Oct 11, 2024

In this PR:

  • Update neptune and W&B refs so the flytekit plugin docs for these plugins link to the flytekit documentation, not the flytesnacks examples
  • Add sections to left nav to match sections in page
  • Copyedits

This is one of three PRs we need to merge in the following order to get the neptune and wandb flytekit plugin docs onto the docs site:

  1. flytesnacks PR (this one) to fix refs in neptune and wandb plugin docs
  2. flyte PR to update monodocs dependencies
  3. flytekit PR to add new flytekit plugin docs for neptune and wandb plugins (after re-running monodocs build)

Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
@neverett neverett self-assigned this Oct 11, 2024
@neverett neverett changed the title DOC-648 flytesnacks edits needed for Neptun and W&B flytekit plugins DOC-648 flytesnacks edits needed for Neptune and W&B flytekit plugins Oct 11, 2024
@neverett neverett changed the title DOC-648 flytesnacks edits needed for Neptune and W&B flytekit plugins DOC-648 flytesnacks edits needed for Neptune and W&B flytekit plugins documentation Oct 11, 2024
…ation notice

Signed-off-by: nikki everett <nikki@union.ai>
@neverett neverett merged commit 1be1081 into master Oct 14, 2024
59 checks passed
@neverett neverett deleted the nikki/fix-plugin-refs branch October 14, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants