Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example for echo task #1724

Merged
merged 5 commits into from
Aug 29, 2024
Merged

Add an example for echo task #1724

merged 5 commits into from
Aug 29, 2024

Conversation

pingsutw
Copy link
Member

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
neverett
neverett previously approved these changes Aug 22, 2024
Copy link
Contributor

@neverett neverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion, otherwise LGTM

pingsutw and others added 2 commits August 22, 2024 12:47
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
@pingsutw
Copy link
Member Author

blocked by flytekit release

@pingsutw pingsutw marked this pull request as draft August 22, 2024 21:00
@pingsutw pingsutw marked this pull request as ready for review August 28, 2024 23:31
Comment on lines +197 to +198
echo = Echo(name="echo", inputs={"radius": float})

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think outputs is more straightforward as output values of an echo task

Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pingsutw pingsutw merged commit 89bf7bc into master Aug 29, 2024
57 checks passed
@pingsutw pingsutw deleted the echo branch August 29, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants