Fixes some CI failures when serializing plugins #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
changed the title
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
neverett
previously approved these changes
Aug 12, 2024
pingsutw
reviewed
Aug 13, 2024
| # training so that state can be shared across workers. | ||
|
|
||
| # %% | ||
| container = V1Container(name=custom_image.name, volume_mounts=[V1VolumeMount(mount_path="/dev/shm", name="dshm")]) |
There was a problem hiding this comment.
With https://github.com/flyteorg/flytekit/pull/2543/files, a shared memory volume is injected by default.
eapolinario
reviewed
Aug 13, 2024
|
I opened flyteorg/flytekit#2682 which should fix the pushing issue. |
eapolinario
previously approved these changes
Aug 13, 2024
FYI: I canceled the CI run because we hit the issue that ^ is going to fix. |
…_serialization_issues Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
eapolinario
previously approved these changes
Aug 22, 2024
pingsutw
previously approved these changes
Aug 22, 2024
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
pingsutw
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.