third iteration: docs restructure #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
|
Flyte.org updates:
Readthedocs redirects:
|
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
cosmicBboy
reviewed
Dec 15, 2023
There was a problem hiding this comment.
changes look good @samhita-alla, just want to make sure we have our bases covered in terms of potential changes needed in CI that rely on some of the old file names (e.g. dynamics.py -> dynamic_workflow.py.
Comment on lines
+10
to
+11
| # Using a map task in Flyte allows for the execution of a pod task or a regular task across a series of inputs within a single workflow node. | ||
| # This capability eliminates the need to create individual nodes for each instance, leading to substantial performance improvements. |
There was a problem hiding this comment.
we're okay removing the blogpost link?
There was a problem hiding this comment.
yep. it was published a long time ago, and i think our docs should suffice.
cosmicBboy
reviewed
Dec 15, 2023
Comment on lines
+75
to
+78
| # ``` | ||
| # pyflyte run --remote \ | ||
| # https://raw.githubusercontent.com/flyteorg/flytesnacks/master/examples/advanced_composition/advanced_composition/chain_entities.py \ | ||
| # chain_tasks_wf |
There was a problem hiding this comment.
let's figure out a way to templatize this at some point (not in this PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR updates examples in the advanced composition section.