Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create FlyIn Plugin Documentation #1314

Merged
merged 32 commits into from
Dec 12, 2023
Merged

Create FlyIn Plugin Documentation #1314

merged 32 commits into from
Dec 12, 2023

Conversation

ByronHsu
Copy link
Contributor

@ByronHsu ByronHsu commented Dec 2, 2023 •
edited
Loading

Added comprehensive flyin user doc

flyteorg/flyte#4284

_Users_byhsu_local-repo_flyte-doc_flytesnacks_docs__build_auto_examples_flyin_plugin_vscode html
_Users_byhsu_local-repo_flyte-doc_flytesnacks_docs__build_auto_examples_flyin_plugin_index html

@ByronHsu ByronHsu mentioned this pull request Dec 8, 2023
Merged
@ByronHsu ByronHsu changed the title Initialize FlyIn Plugin Documentation Create FlyIn Plugin Documentation Dec 8, 2023
@ByronHsu ByronHsu force-pushed the byhsu/flyin branch 2 times, most recently from 0f4c794 to 35d51b8 Compare December 8, 2023 18:07
pingsutw
pingsutw reviewed Dec 8, 2023
View reviewed changes
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neverett mind taking a look as well

Makefile Outdated Show resolved Hide resolved
neverett
neverett requested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@neverett neverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this! Let me know if you have any questions about my suggestions.

examples/flyin_plugin/flyin_plugin/vscode.py Outdated Show resolved Hide resolved
examples/flyin_plugin/flyin_plugin/vscode.py Outdated Show resolved Hide resolved
examples/flyin_plugin/flyin_plugin/vscode.py Outdated Show resolved Hide resolved
examples/flyin_plugin/flyin_plugin/vscode.py Outdated Show resolved Hide resolved
examples/flyin_plugin/flyin_plugin/vscode.py Outdated Show resolved Hide resolved
examples/flyin_plugin/flyin_plugin/vscode.py Outdated Show resolved Hide resolved
examples/flyin_plugin/flyin_plugin/vscode.py Outdated Show resolved Hide resolved
examples/flyin_plugin/README.md Outdated Show resolved Hide resolved
examples/flyin_plugin/README.md Outdated Show resolved Hide resolved
examples/flyin_plugin/flyin_plugin/vscode.py Outdated Show resolved Hide resolved
@ByronHsu
Copy link
Contributor Author

@neverett I resolved most of them. can you take a look again?

@neverett
Copy link
Contributor

@ByronHsu I added a few comments, let me know what you think! Once those are resolved, I can approve this PR.

@ByronHsu
Copy link
Contributor Author

@neverett fixed all comments

@ByronHsu
Copy link
Contributor Author

@neverett @pingsutw can you help me rerun the CI? seems that it is stuck

ByronHsu and others added 17 commits December 12, 2023 00:44
@ByronHsu
init
ca41184 
Signed-off-by: byhsu <byhsu@linkedin.com>
@ByronHsu
nit
e7fae12 
Signed-off-by: Future Outlier <eric901201@gmai.com>
@ByronHsu
add v1 by han-ru
249f6fa 
Signed-off-by: Future Outlier <eric901201@gmai.com>
@ByronHsu
v2
374d0db 
Signed-off-by: Future Outlier <eric901201@gmai.com>
@ByronHsu
v3
961660b 
Signed-off-by: Future Outlier <eric901201@gmai.com>
@ByronHsu
v4
f9a1067 
Signed-off-by: Future Outlier <eric901201@gmai.com>
@ByronHsu
test
dcb005d 
Signed-off-by: Future Outlier <eric901201@gmai.com>
@ByronHsu
update dep
7abb475 
Signed-off-by: byhsu <byhsu@linkedin.com>
@ByronHsu
polish
65c6179 
Signed-off-by: byronhsu <byronhsu1230@gmail.com>
@ByronHsu
lint
eb7a57b 
Signed-off-by: byronhsu <byronhsu1230@gmail.com>
@ByronHsu
fix image
c742cc7 
Signed-off-by: byronhsu <byronhsu1230@gmail.com>
@ByronHsu
fix import
e10f15c 
Signed-off-by: byronhsu <byronhsu1230@gmail.com>
@ByronHsu @pingsutw
Update Makefile
65b51c3 
Co-authored-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: ByronHsu <byronhsu1230@gmail.com>
@ByronHsu @neverett
Update examples/flyin_plugin/flyin_plugin/vscode.py
ad5c8ed 
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: ByronHsu <byronhsu1230@gmail.com>
@ByronHsu @neverett
Update examples/flyin_plugin/flyin_plugin/vscode.py
8f41cc4 
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: ByronHsu <byronhsu1230@gmail.com>
@ByronHsu @neverett
Update examples/flyin_plugin/flyin_plugin/vscode.py
922df0d 
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: ByronHsu <byronhsu1230@gmail.com>
@ByronHsu @neverett
Update examples/flyin_plugin/flyin_plugin/vscode.py
e23b832 
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: ByronHsu <byronhsu1230@gmail.com>
ByronHsu and others added 14 commits December 12, 2023 00:44
@ByronHsu @neverett
Update examples/flyin_plugin/flyin_plugin/vscode.py
6c48c0c 
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: ByronHsu <byronhsu1230@gmail.com>
@ByronHsu @neverett
Update examples/flyin_plugin/flyin_plugin/vscode.py
8087eb1 
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: ByronHsu <byronhsu1230@gmail.com>
@ByronHsu @neverett
Update examples/flyin_plugin/flyin_plugin/vscode.py
cf04b79 
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: ByronHsu <byronhsu1230@gmail.com>
@ByronHsu @neverett
Update examples/flyin_plugin/flyin_plugin/vscode.py
84840dd 
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: ByronHsu <byronhsu1230@gmail.com>
@ByronHsu @neverett
Update examples/flyin_plugin/flyin_plugin/vscode.py
f4b3cb6 
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: ByronHsu <byronhsu1230@gmail.com>
@ByronHsu @neverett
Update examples/flyin_plugin/flyin_plugin/vscode.py
3dc05be 
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: ByronHsu <byronhsu1230@gmail.com>
@ByronHsu @neverett
Update examples/flyin_plugin/flyin_plugin/vscode.py
411cfcc 
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: ByronHsu <byronhsu1230@gmail.com>
@ByronHsu @neverett
Update examples/flyin_plugin/flyin_plugin/vscode.py
9ea80bf 
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: ByronHsu <byronhsu1230@gmail.com>
@ByronHsu @neverett
Update examples/flyin_plugin/flyin_plugin/vscode.py
1d9094f 
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: ByronHsu <byronhsu1230@gmail.com>
@ByronHsu @neverett
Update examples/flyin_plugin/README.md
f631105 
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: ByronHsu <byronhsu1230@gmail.com>
@ByronHsu @neverett
Update examples/flyin_plugin/README.md
a43599f 
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: ByronHsu <byronhsu1230@gmail.com>
@ByronHsu @neverett
Update examples/flyin_plugin/flyin_plugin/vscode.py
0abcee8 
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: ByronHsu <byronhsu1230@gmail.com>
@ByronHsu
minor
1c27ec6 
Signed-off-by: byronhsu <byronhsu1230@gmail.com>
@ByronHsu
resolve cmt
b39aefc 
Signed-off-by: byronhsu <byronhsu1230@gmail.com>
@ByronHsu
trigger
79d6f6a 
Signed-off-by: byronhsu <byronhsu1230@gmail.com>
@neverett neverett mentioned this pull request Dec 12, 2023
Merged
3 tasks
@neverett
Copy link
Contributor

@ByronHsu we made some changes to the docs structure recently -- flyteorg/flyte#4582 should fix the failing CI.

@ByronHsu
Copy link
Contributor Author

@cosmicBboy @thomasjpfan "monodocs build" keeps failing. Seems related to the PR you made. Can you help taking a looK?

@pingsutw pingsutw merged commit 58a6cb4 into flyteorg:master Dec 12, 2023
94 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pingsutw pingsutw pingsutw left review comments

@neverett neverett neverett approved these changes

@kumare3 kumare3 Awaiting requested review from kumare3

@wild-endeavor wild-endeavor Awaiting requested review from wild-endeavor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ByronHsu @neverett @pingsutw