Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Send task execution metadata to out-core plugin #369

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

honnix
Copy link
Member

@honnix honnix commented Jul 3, 2023

TL;DR

Send task execution metadata to out-core plugin when creating a task.

This depends on flyteorg/flyteidl#422

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

As described in flyteorg/flyte#3824, for certain type of use cases, the task execution metadata would be desired to have.

Tracking Issue

Closes flyteorg/flyte#3824

Follow-up issue

NA

@honnix honnix force-pushed the agent-task-execution-metadata branch from 25ff6dc to acd4672 Compare July 3, 2023 13:05
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #369 (624cc6c) into master (f7b37aa) will increase coverage by 1.44%.
The diff coverage is 87.73%.

❗ Current head 624cc6c differs from pull request most recent head 1d0254d. Consider uploading reports for the commit 1d0254d to get more accurate results

@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
+ Coverage   62.90%   64.34%   +1.44%     
==========================================
  Files         153      154       +1     
  Lines       12893    10573    -2320     
==========================================
- Hits         8110     6803    -1307     
+ Misses       4170     3157    -1013     
  Partials      613      613              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/tasks/logs/config.go 0.00% <ø> (ø)
go/tasks/pluginmachinery/flytek8s/config/config.go 50.00% <ø> (ø)
...s/pluginmachinery/tasklog/templatescheme_enumer.go 0.00% <0.00%> (ø)
go/tasks/logs/logging_utils.go 89.70% <100.00%> (+1.47%) ⬆️
go/tasks/pluginmachinery/catalog/hashing.go 94.73% <100.00%> (+0.39%) ⬆️
go/tasks/pluginmachinery/flytek8s/pod_helper.go 71.07% <100.00%> (-2.59%) ⬇️
go/tasks/pluginmachinery/tasklog/template.go 98.60% <100.00%> (+1.30%) ⬆️
go/tasks/plugins/array/k8s/subtask.go 30.35% <100.00%> (-0.14%) ⬇️
go/tasks/plugins/array/k8s/subtask_exec_context.go 83.18% <100.00%> (+3.98%) ⬆️
go/tasks/plugins/k8s/dask/dask.go 86.12% <100.00%> (+3.24%) ⬆️
... and 8 more

... and 119 files with indirect coverage changes

go.mod Outdated Show resolved Hide resolved
@honnix honnix marked this pull request as ready for review July 3, 2023 13:09
@honnix honnix requested a review from pingsutw July 3, 2023 13:09
@hamersaw
Copy link
Contributor

@honnix sorry about the delay, can you update this PR with the flyteidl merge?

Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>
@honnix honnix force-pushed the agent-task-execution-metadata branch from acd4672 to 1d0254d Compare July 19, 2023 17:32
@honnix
Copy link
Member Author

honnix commented Jul 19, 2023

@hamersaw I fixed that.

@hamersaw hamersaw merged commit 3405f89 into flyteorg:master Jul 20, 2023
7 checks passed
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core feature] Pass task execution metadata to out-core plugin
2 participants