Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Implementing Agent Metadata Service #5109

Closed
wants to merge 1 commit into from

Conversation

Future-Outlier
Copy link
Member

Tracking issue

#3936

Why are the changes needed?

Make users implement their own agent metadata service.

What changes were proposed in this pull request?

Add Implementing Agent Metadata Service documentation.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Future-Outlier <eric901201@gmail.com>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. documentation Improvements or additions to documentation labels Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.01%. Comparing base (d68047a) to head (a0c675a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5109      +/-   ##
==========================================
+ Coverage   58.56%   59.01%   +0.45%     
==========================================
  Files         494      645     +151     
  Lines       42987    55670   +12683     
==========================================
+ Hits        25176    32855    +7679     
- Misses      15816    20221    +4405     
- Partials     1995     2594     +599     
Flag Coverage Δ
unittests 59.01% <ø> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neverett
Copy link
Contributor

neverett commented Apr 1, 2024

Would you be able to add these changes to #5106 so all changes to the agents docs can be reviewed together? Thanks!

@Future-Outlier Future-Outlier marked this pull request as draft April 2, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants