Deprecated Agent State to Agent Phase

[Future-Outlier]

Tracking issue

Fixes #3936

Why are the changes needed?

We want to deprecate State in webapi and use core.TaskExecution.Phase instead to make users less confused.

What changes were proposed in this pull request?

• add core.TaskExecution.Phase phase in agent.proto
• add DEPRECATED annotation in State in agent.proto
• add switch case statements to route the phase in agent/plugin.go
• add tests for above

Note:
The reason why we need to:

1. check the phase
2. check the state

is because the default value of phase is UNDEFINED, and the default value of state is RETRYABLE FAILURE.
We can check the state when the phase is UNDEFINED.

How was this patch tested?

• single binary and flytekit here
• unit test

Setup process

0. start agent server by flytekit
1. start flyte components with --dev
2. compile and start the flyte cluster
3. run a remote task with sensor agent

pyflyte serve agent

flytectl demo start --dev

cd flyte
make compile;
flyte start --config ../flyte-single-binary-local-dev.yaml

pyflyte run --remote sensor_example.py wf

tasks:
  task-plugins:
    enabled-plugins:
      - agent-service

plugins:
  agent-service:
    supportedTaskTypes:
      - sensor
    defaultAgent:
      endpoint: "dns:///localhost:8000"
      insecure: true
      timeouts:
        GetTask: 100s
      defaultTimeout: 100s

from flytekit.sensor.file_sensor import FileSensor
from flytekit import ImageSpec, task, workflow
sensor = FileSensor(name="test_sensor")

@task()
def t1():
    return

@workflow()
def wf():
    sensor(path="/tmp") >> t1()

if __name__ == "__main__":
    wf()

Screenshots

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

flyteorg/flytekit#2123

[codecov]

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (6f5c471) 58.18% compared to head (a8ab04e) 58.18%.
Report is 9 commits behind head on master.

Files	Patch %	Lines
...yteplugins/go/tasks/plugins/webapi/agent/plugin.go	61.53%	9 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4738   +/-   ##
=======================================
  Coverage   58.18%   58.18%           
=======================================
  Files         626      626           
  Lines       53833    53858   +25     
=======================================
+ Hits        31322    31337   +15     
- Misses      20003    20012    +9     
- Partials     2508     2509    +1     

Flag	Coverage Δ
unittests	58.18% <61.53%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.