fix

Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
flyteorg · Sep 10, 2024 · b8a1c4e · b8a1c4e
1 parent 3ee2f0f
commit b8a1c4e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/flytepropeller/pkg/controller/controller.go b/flytepropeller/pkg/controller/controller.go
@@ -436,14 +436,14 @@ func New(ctx context.Context, cfg *config.Config, kubeClientset kubernetes.Inter
 
 	recoveryClient := recovery.NewClient(adminClient)
 	nodeHandlerFactory, err := factory.NewHandlerFactory(ctx, launchPlanActor, launchPlanActor,
-		kubeClient, kubeClientset, catalogClient, recoveryClient, &cfg.EventConfig, cfg.ClusterID, signalClient, scope)
+		kubeClient, kubeClientset, catalogClient, recoveryClient, &cfg.EventConfig, cfg.LiteralOffloadingConfig, cfg.ClusterID, signalClient, scope)
 	if err != nil {
 		return nil, errors.Wrapf(err, "failed to create node handler factory")
 	}
 
 	nodeExecutor, err := nodes.NewExecutor(ctx, cfg.NodeConfig, store, controller.enqueueWorkflowForNodeUpdates, eventSink,
 		launchPlanActor, launchPlanActor, storage.DataReference(cfg.DefaultRawOutputPrefix), kubeClient,
-		catalogClient, recoveryClient, &cfg.EventConfig, cfg.ClusterID, signalClient, nodeHandlerFactory, scope)
+		catalogClient, recoveryClient, cfg.LiteralOffloadingConfig, &cfg.EventConfig, cfg.ClusterID, signalClient, nodeHandlerFactory, scope)
 	if err != nil {
 		return nil, errors.Wrapf(err, "Failed to create Controller.")
 	}

diff --git a/flytepropeller/pkg/controller/nodes/common/utils.go b/flytepropeller/pkg/controller/nodes/common/utils.go
@@ -82,7 +82,7 @@ func GetTargetEntity(ctx context.Context, nCtx interfaces.NodeExecutionContext)
 // OffloadLargeLiteral offloads the large literal if meets the threshold conditions
 func OffloadLargeLiteral(ctx context.Context, datastore *storage.DataStore, dataReference storage.DataReference,
 	toBeOffloaded *idlcore.Literal, literalOffloadingConfig config.LiteralOffloadingConfig) error {
-	literalSizeBytes := uint64(proto.Size(toBeOffloaded))
+	literalSizeBytes := int64(proto.Size(toBeOffloaded))
 	literalSizeMB := literalSizeBytes / MB
 	// check if the literal is large
 	if literalSizeMB >= literalOffloadingConfig.MaxSizeInMBForOffloading {
@@ -112,7 +112,7 @@ func OffloadLargeLiteral(ctx context.Context, datastore *storage.DataStore, data
 	toBeOffloaded.Value = &idlcore.Literal_OffloadedMetadata{
 		OffloadedMetadata: &idlcore.LiteralOffloadedMetadata{
 			Uri:          dataReference.String(),
-			SizeBytes:    literalSizeBytes,
+			SizeBytes:    uint64(literalSizeBytes),
 			InferredType: inferredType,
 		},
 	}