Skip to content

Commit

Permalink
Since there no longer is a canonical "classic" version, be explicit
Browse files Browse the repository at this point in the history
  • Loading branch information
rubys committed Nov 21, 2023
1 parent 2aef330 commit b05b04b
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 2 deletions.
2 changes: 1 addition & 1 deletion templates/Dockerfile.ejs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ WORKDIR /app

# Set production environment
<%- emitEnv(baseEnv) %>
<% if (yarn && yarnVersion != yarnClassic) { -%>
<% if (yarn) { -%>
ARG YARN_VERSION=<%= yarnVersion %>
<% if(yarnVersion.startsWith('3.')) {-%>
Expand Down
2 changes: 2 additions & 0 deletions test/base/cache-yarn/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ WORKDIR /app

# Set production environment
ENV NODE_ENV="production"
ARG YARN_VERSION=xxx
RUN npm install -g yarn@$YARN_VERSION --force


# Throw-away build stage to reduce size of final image
Expand Down
2 changes: 2 additions & 0 deletions test/frameworks/next-yarn/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ WORKDIR /app

# Set production environment
ENV NODE_ENV="production"
ARG YARN_VERSION=xxx
RUN npm install -g yarn@$YARN_VERSION --force


# Throw-away build stage to reduce size of final image
Expand Down
2 changes: 2 additions & 0 deletions test/frameworks/nuxt/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ WORKDIR /app

# Set production environment
ENV NODE_ENV="production"
ARG YARN_VERSION=xxx
RUN npm install -g yarn@$YARN_VERSION --force


# Throw-away build stage to reduce size of final image
Expand Down
2 changes: 1 addition & 1 deletion test/frameworks/vite/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# syntax = docker/dockerfile:1

# Adjust NODE_VERSION as desired
ARG NODE_VERSION=21.2.0
ARG NODE_VERSION=xxx
FROM node:${NODE_VERSION}-slim as base

LABEL fly_launch_runtime="Vite"
Expand Down

0 comments on commit b05b04b

Please sign in to comment.