Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle delete before adding finalizer #1177

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Handle delete before adding finalizer #1177

merged 1 commit into from
Jul 31, 2023

Commits on Jul 31, 2023

  1. Handle delete before adding finalizer 

    In Reconcile() methods, move the object deletion above add finalizer.
Finalizers can't be set when an object is being deleted.

Introduce a cacheless client in suite_test to use for testing this
change. It ensures that the Reconcile() call always operates on the
latest version of the object which has the deletion timestamp and
existing finalizer.

Signed-off-by: Sunny <darkowlzz@protonmail.com>
    @darkowlzz
    darkowlzz committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    ca0f0ff View commit details
    Browse the repository at this point in the history