Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shareable providers #743

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rsafonseca
Copy link

@rsafonseca rsafonseca commented Feb 15, 2024

Provides the ability for sharing a provider across namespaces.
Provides the ability for multiple alerts to share the same provider and post to different channels.

This avoids having to create a single provider for each channel created, reducing the number of necessary CRs when a provider can support multiple channels.

This avoids having to create a secret in every namespace that needs to use a provider to send notifications, which might not be desirable not only because of the sheer number of required objects, but also because the secret that the provider uses might not be something we want to share with owners of other namespaces.

Overall, this alleviates the usage of providers and alerts in large multi-tenant environments, as well as in smaller environments that might want to simplify their usage.

This also does not change the current default behaviour. Providers are still namespace bound by default unless specifically allowed in their spec to be used across namespaces, for security reasons.

Addresses #125

Signed-off-by: Rafael da Fonseca <rafael.fonseca@wildlifestudios.com>
@rsafonseca
Copy link
Author

@stefanprodan would you be able to take a look? 👀
Thanks! :D

Signed-off-by: Rafael da Fonseca <rafael.fonseca@wildlifestudios.com>
@stefanprodan stefanprodan added the hold Issues and pull requests put on hold label Feb 16, 2024
@stefanprodan
Copy link
Member

This needs an RFC https://github.com/fluxcd/flux2/tree/main/rfcs

@rsafonseca
Copy link
Author

Here you go @stefanprodan fluxcd/flux2#4612 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Issues and pull requests put on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants